Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for signedness compiler warning #506

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix for signedness compiler warning #506

merged 1 commit into from
Feb 15, 2023

Conversation

shikokuchuo
Copy link
Contributor

Eliminates the following compiler warning:

whisper.cpp:3868:55: warning: comparison of integer expressions of different signedness: ‘std::vector<whisper_full(whisper_context*, whisper_full_params, const float*, int)::beam_candidate>::size_type’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
 3868 |                         while (beam_candidates.size() > cur_c && beam_candidates[cur_c].sequence.sum_logprobs_all == cur.sequence.sum_logprobs_all && i > 0) {
      |                                ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

gcc 11.3.0 on Ubuntu 22.04 using cmake.

Re-submitting a clean PR - apologies not sure what happened in #497 ...

@ggerganov ggerganov merged commit 0336161 into ggerganov:master Feb 15, 2023
rock3125 pushed a commit to rock3125/whisper.cpp that referenced this pull request Feb 21, 2023
@shikokuchuo @rock3125
whisper : fix signedness compiler warning (ggerganov#506)
a0f28a5
anandijain pushed a commit to anandijain/whisper.cpp that referenced this pull request Apr 28, 2023
@shikokuchuo
whisper : fix signedness compiler warning (ggerganov#506)
90bc5b9
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@shikokuchuo
whisper : fix signedness compiler warning (ggerganov#506)
6b1fa13
jacobwu-b pushed a commit to jacobwu-b/Transcriptify-by-whisper.cpp that referenced this pull request Oct 24, 2023
@shikokuchuo
whisper : fix signedness compiler warning (ggerganov#506)
52f9bc1
landtanin pushed a commit to landtanin/whisper.cpp that referenced this pull request Dec 16, 2023
@shikokuchuo
whisper : fix signedness compiler warning (ggerganov#506)
ecf0302
iThalay pushed a commit to iThalay/whisper.cpp that referenced this pull request Sep 23, 2024
@shikokuchuo @iThalay
whisper : fix signedness compiler warning (ggerganov#506)
dc2d8aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikokuchuo @ggerganov